-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: chain agnostic #278
Merged
Merged
feat: chain agnostic #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
geekbrother
approved these changes
Jan 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. I think it's better to migrate the existing database and safer.
chris13524
force-pushed
the
feat/cross-chain
branch
from
January 12, 2024 17:24
6f07e56
to
d1a05d8
Compare
geekbrother
approved these changes
Jan 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
get_address_lower()
function when doing SQL queries.is_eip155_account()
in theverify_identity()
functionis_same_address()
check. This was not a high-risk issue because it required already knowing the symmetric key of the topic, which is private information anyway.update_subscriber()
parameters to take subscriber ID instead of project and account, to simplify, improve performance, and reduce risk of security vulnerabilities (i.e. using the same subscriber that was looked up earlier in the function)upsert_subscriber()
to also returnaccount
of the subscriber so that analytics can export a consistent account regardless of which account was used for the requestResolves #265
How Has This Been Tested?
New automated tests
Due Diligence