feat: partial prepareCalls impl #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris13524
force-pushed
the
feat/wallet-service
branch
from
e9f08ff to
63b5319
Compare
…nto feat/wallet-service
chris13524
force-pushed
the
feat/wallet-service
branch
3 times, most recently
from
db27fe3 to
a8f4556
Compare
chris13524
force-pushed
the
feat/wallet-service
branch
from
a8f4556 to
5618a86
Compare
geekbrother
reviewed
Sep 26, 2024
|
|
||
| let pimlico_client = BundlerClient::new(BundlerConfig::new( | ||
| format!( | ||
| "https://rpc.walletconnect.com/v1/bundler?chainId={}&projectId={}&bundler=pimlico", |
There was a problem hiding this comment.
We can use bundler_rpc_call instead of the direct URL request.
There was a problem hiding this comment.
I would like to use this; but I need to refactor the library to support this sort of arbitrary function call vs needing an HTTP request.
geekbrother
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Functional implementation of prepareCalls according to these specs. Just duping this all in this repo for now to get this working, we can refactor into yttrium in another PR. There are a few details remaining to be implemented, but these will also be in a follow-up PR:
Also updates copyright.
Depends on reown-com/yttrium#28
Depends on https://walletconnect.slack.com/archives/C03SCF66K2T/p1727098325949169
How Has This Been Tested?
Not tested
Due Diligence