Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(grafana): adding handlers execution time, rps chart and alert #755

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

geekbrother
Copy link
Contributor

@geekbrother geekbrother commented Aug 28, 2024

Description

This PR adds a Grafana chart for the handler's execution time. The alert was added for more than 3 seconds of execution time for 5 minutes on average. This alert will help to catch possible blocking and long execution times that can affect the user's experience.

The panel for Handlers requests per second was also added.

Resolves #750

How Has This Been Tested?

  • Tested by placing the query into Grafana.

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@geekbrother geekbrother self-assigned this Aug 28, 2024
@geekbrother geekbrother changed the title feat(grafana): adding handlers execution chart and alert feat(grafana): adding handlers execution time, rps chart and alert Aug 28, 2024
@geekbrother geekbrother marked this pull request as ready for review August 28, 2024 13:35
@geekbrother geekbrother force-pushed the feat/improving_observation branch from 51accc1 to 77e9b9c Compare August 28, 2024 14:52
@geekbrother geekbrother force-pushed the feat/improving_observation branch from 77e9b9c to 8fad70e Compare August 29, 2024 10:26
@geekbrother geekbrother merged commit 52978f2 into master Aug 29, 2024
11 checks passed
@geekbrother geekbrother deleted the feat/improving_observation branch August 29, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metrics for endpoint latency + req/s
3 participants