fix(rpc): passing through a bad request error from the RPC provider (…

…#741)

* fix(rpc): adding proper handling of the bad request

* feat(tests): adding integration test

* fix: removing unnecessary comparing with the http 400

integration/proxy.test.ts

@@ -30,4 +30,21 @@ describe('Proxy', () => {
     )
     expect(resp.status).toBe(401)
   })
+
+  it('Bad JSON-RPC request', async () => {
+    // Missing the id field
+    const payload = {
+      jsonrpc: "2.0",
+      method: "eth_chainId",
+      params: [],
+    };
+    const chainId = "eip155:11155111";
+
+    let resp: any = await httpClient.post(
+      `${baseUrl}/v1?chainId=${chainId}&projectId=${projectId}`,
+      payload
+    )
+    expect(resp.status).toBe(400)
+    expect(typeof resp.data).toBe('object')
+  })
 })

src/handlers/proxy.rs

@@ -207,7 +207,7 @@ pub async fn rpc_provider_call(
     );
 
     match response.status() {
-        http::StatusCode::OK => {
+        http::StatusCode::OK | http::StatusCode::BAD_REQUEST => {
             state.metrics.add_finished_provider_call(provider.borrow());
         }
         _ => {