-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: sign client deeplink #3821
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
9 Skipped Deployments
|
if (this.options.manualWCControl) { | ||
ConnectionController.finalizeWcConnection() | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tomiir manualWCControler
is only used for sign client right ? If so i added a logic here to setup deep link once we close the modal since sign client doesn't have connect
event which we could listen to.
I tried session_update
event, but that doesn't work as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just double check this doesnt break manual integrations on universal provider given in there the connect
IS fired
Description
Deeplink UX is broken when using sign client examples
Type of change
Associated Issues
For Linear issues: Closes APKT-2249
For GH issues: closes #...
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist