Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sign client deeplink #3821

Merged
merged 4 commits into from
Feb 10, 2025
Merged

Conversation

magiziz
Copy link
Contributor

@magiziz magiziz commented Feb 7, 2025

Description

Deeplink UX is broken when using sign client examples

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-2249
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

changeset-bot bot commented Feb 7, 2025

⚠️ No Changeset found

Latest commit: c9930a9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Feb 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 9, 2025 3:07am
appkit-ethers5-bera ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 9, 2025 3:07am
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 9, 2025 3:07am
9 Skipped Deployments
Name Status Preview Comments Updated (UTC)
appkit-basic-ep ⬜️ Ignored (Inspect) Visit Preview Feb 9, 2025 3:07am
appkit-basic-ep-example ⬜️ Ignored (Inspect) Feb 9, 2025 3:07am
appkit-basic-example ⬜️ Ignored (Inspect) Visit Preview Feb 9, 2025 3:07am
appkit-basic-sign-client-example ⬜️ Ignored (Inspect) Visit Preview Feb 9, 2025 3:07am
appkit-basic-up-example ⬜️ Ignored (Inspect) Visit Preview Feb 9, 2025 3:07am
appkit-vue-solana ⬜️ Ignored (Inspect) Feb 9, 2025 3:07am
appkit-wagmi-cdn-example ⬜️ Ignored (Inspect) Feb 9, 2025 3:07am
ethereum-provider-wagmi-example ⬜️ Ignored (Inspect) Visit Preview Feb 9, 2025 3:07am
vue-wagmi-example ⬜️ Ignored (Inspect) Feb 9, 2025 3:07am

Comment on lines +58 to +60
if (this.options.manualWCControl) {
ConnectionController.finalizeWcConnection()
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomiir manualWCControler is only used for sign client right ? If so i added a logic here to setup deep link once we close the modal since sign client doesn't have connect event which we could listen to.

I tried session_update event, but that doesn't work as well.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just double check this doesnt break manual integrations on universal provider given in there the connect IS fired

Copy link

linear bot commented Feb 10, 2025

@magiziz magiziz merged commit b82d7ed into feat/appkit-basic-class Feb 10, 2025
13 checks passed
@magiziz magiziz deleted the fix/sign-client-deeplink branch February 10, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants