refactor: solana walletconnect rpc interface #2677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
glitch-txs
approved these changes
Aug 7, 2024
enesozturk
reviewed
Aug 8, 2024
| } from '@solana/web3.js' | ||
|
|
||
| import { solana } from '../../utils/ChainsUtil' | ||
| import { useChakraToast } from '../Toast' | ||
|
|
||
| const PHANTOM_TESTNET_ADDRESS = '8vCyX7oB6Pc3pbWMGYYZF5pbSnAdQ7Gyr32JqxqCy8ZR' | ||
| const recipientAddress = new PublicKey(PHANTOM_TESTNET_ADDRESS) | ||
| const amountInLamports = 100000000 | ||
| const amountInLamports = 10000000 |
There was a problem hiding this comment.
Can we use underscores for better readability?
Suggested change
| const amountInLamports = 10000000 | |
| const amountInLamports = 10_000_000 |
enesozturk
reviewed
Aug 8, 2024
|
|
||
| import { solana } from '../../utils/ChainsUtil' | ||
| import { useChakraToast } from '../Toast' | ||
|
|
||
| const PHANTOM_TESTNET_ADDRESS = '8vCyX7oB6Pc3pbWMGYYZF5pbSnAdQ7Gyr32JqxqCy8ZR' | ||
| const recipientAddress = new PublicKey(PHANTOM_TESTNET_ADDRESS) | ||
| const amountInLamports = 50000000 | ||
| const amountInLamports = 10000000 |
enesozturk
reviewed
Aug 8, 2024
enesozturk
approved these changes
Aug 8, 2024
tomiir
reviewed
Aug 8, 2024
tomiir
reviewed
Aug 8, 2024
| import { OptionsController } from '@web3modal/core' | ||
|
|
||
| import { SolStoreUtil } from '../utils/scaffold/index.js' | ||
| import { UniversalProviderFactory } from './universalProvider.js' | ||
| import { BaseConnector } from './baseConnector.js' | ||
| import { BaseConnector, type Connector } from './baseConnector.js' |
There was a problem hiding this comment.
split regular imports and type imports:
Suggested change
| import { BaseConnector, type Connector } from './baseConnector.js' | |
| import { BaseConnector } from './baseConnector.js' | |
| import type { Connector } from './baseConnector.js' |
tomiir
approved these changes
Aug 8, 2024
…or/solana-wallet-rpc-interface
…letConnect/web3modal into refactor/solana-wallet-rpc-interface
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is updating the Solana's WalletConnectConnector RPC requests to use serialized transactions instead of object to communicate with wallets. For further work we should make adapter and walletConnectConnector to implement a same interface which is then used by the library consumers.
This PR is related to reown-com/web-examples#672
Type of change
Associated Issues
For Linear issues: Closes APKT-xxx
For GH issues: closes #...
Showcase (Optional)
Screen.Recording.2024-08-07.at.18.12.26.mov
Checklist