-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dav1d to replace aom, upgrade ffmpeg to 4.4.5 #136
base: master
Are you sure you want to change the base?
Conversation
this will fix `libavcodec/libdav1d.c:143:7: error: no member named 'n_tile_threads' in 'struct Dav1dSettings'` when build
`env2mfile` requires meson 0.62.0, but Ubuntu 22.04's meson is 0.61.2
What versions of windows does this support? We're going to support Windows 7 for the next release. |
I tested it on Windows 7 using VMware, I am sure that av1 video can be played normally. But I think if decided to continue compatible with Windows 7, a parameter like |
i like to keep all platforms on the same versions as much as possible, just because it minimizes how much I have to test. With so many platforms, there's only so much testing we can do. That being said, Windows 7 is scheduled to be dropped soon, so it probably makes sense to take these changes early in the 8.4 release process. |
Although renpy has used aom as av1/avif's decoder, both
fmpeg
andlibavif
are usingdav1d
as the default decoder for AV1, Android 12 and newer version are using dav1d too, so it's good to let dav1d to replace aom.When building ffmpeg with dav1d, it failed with
libavcodec/libdav1d.c:143:7: error: no member named 'n_tile_threads' in 'struct Dav1dSettings'
, so updating ffmpeg to 4.4.4 to fix this error.Choosing ffmpeg 4.4.4 because this version is still maintained by many distributions, can be patched easily using patches from these distributions.
Benchmarking on my r5 5600h laptop, decoding av1 video using ffmpeg built with dav1d was more than twice as fast as original ffmpeg with aom.
Test compiled successfully on android armeabi_v7a, windows x86_64, wasm, linux x86_64, linux armv7l, mac arm64.
FFmpeg Decoding Benchmark