Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor parameter and variable names for clarity in the future-genetic benchmark #463

Merged

Conversation

lovisek
Copy link
Contributor

@lovisek lovisek commented Nov 21, 2024

Renamed chromosome_count to population_size to better reflect its role. The benchmark generates a population of 50 genotypes, each containing a single chromosome with 200 double Genes. Evolution is computed for the population, and at the end, the best genotype is selected, and its chromosome is returned. Since the term chromosome_count=50 was misleading, this change improves clarity.

Renamed chromosomeRandom to genotypeRandom, as this random generator is responsible for creating new random genotypes, not chromosomes.

Copy link
Member

@lbulej lbulej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It changes an externally visible parameter, but I don't think users of Renaissance are commonly changing those. I think it should be enough to point out this change in the release notes.

@lbulej lbulej merged commit cb64790 into renaissance-benchmarks:master Nov 22, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants