Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch Hadoop Client API jar to avoid deprecated Java Security API #453

Merged
merged 3 commits into from
Oct 23, 2024
Merged

Patch Hadoop Client API jar to avoid deprecated Java Security API #453

merged 3 commits into from
Oct 23, 2024

Conversation

lbulej
Copy link
Member

@lbulej lbulej commented Oct 9, 2024

Uses ASM to patch the UserGroupInformation class at build time and stores it in a version-specific directory of a newly created multi-release jar, where it will be picked up by Java 23+.

This is a temporary solution, but it may be a long-term temporary solution.

Fixes #439.

lbulej added 2 commits October 9, 2024 01:52
@lbulej
Patch Hadoop Client API jar to avoid deprecated Java Security API
f786eaf 
Uses ASM to patch UserGroupInformation class at build time and stores
it in a version-specific directory of a newly created multi-release
jar, where it will be picked up by Java 23+.
@lbulej
Patch Hadoop Client API also in JMH builds
6d955f2
@lbulej lbulej marked this pull request as ready for review October 9, 2024 08:54
@lbulej lbulej requested a review from farquet October 9, 2024 08:57
lbulej
lbulej commented Oct 16, 2024
View reviewed changes
tools/ci/common.sh Outdated Show resolved Hide resolved
lbulej
lbulej commented Oct 16, 2024
View reviewed changes
.github/workflows/main.yml Outdated Show resolved Hide resolved
lbulej
lbulej commented Oct 16, 2024
View reviewed changes
.github/workflows/main.yml Outdated Show resolved Hide resolved
@lbulej
Copy link
Member Author

lbulej commented Oct 18, 2024

I think we don't need jdk23 in the linux-jdks section, it is run in the linux section of the main workflow already. Also, we used to run the EA versions only in the ea-jdk worklflow set up for manual trigger, do we need to run it in the main workflow? It makes the main workflow larger again. If we were to compile only once, it would be fine, but this just makes it longer again.

If we are worried that we don't test on EA releases, we can make the ea-jdk to be something that is triggered on merges to master without any relation to PRs.

@vhotspur
Copy link
Member

I have squashed the CI changes, hopefully it is ready now (runs on 23, extra jobs for LTS releases).

farquet
farquet approved these changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@farquet farquet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lbulej lbulej merged commit 838c1db into master Oct 23, 2024
17 checks passed
@lbulej lbulej deleted the issue/439 branch November 11, 2024 12:41
@mur47x111
Copy link
Collaborator

We need a release including this patch. Currently we cannot run renaissance with latest JDK due to openjdk/jdk#21498

@lbulej
Copy link
Member Author

lbulej commented Nov 12, 2024

I'm pushing towards the release (I think that #456 and possibly #455 are the last to go in, unless something critical comes up).

@farquet farquet mentioned this pull request Nov 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vhotspur vhotspur vhotspur left review comments

@farquet farquet farquet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spark benchmarks broken by JDK-8296244
4 participants
@lbulej @vhotspur @mur47x111 @farquet