Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds several Lean backends for built-in SAIL functions (mostly arithmetic and equality) #954

Open
wants to merge 8 commits into
base: sail2
Choose a base branch
from

Conversation

benjaminselfridge
Copy link
Collaborator

@benjaminselfridge benjaminselfridge commented Feb 3, 2025

Add annotations for the following SAIL builtins:

From arith.sail:

  • add_int
  • sub_int
  • negate_atom
  • negate_int
  • mult_atom
  • mul_int
  • max_int
  • min_int

From flow.sail:

  • eq_unit
  • not_bool
  • lteq_int
  • gteq_int
  • lt_int
  • gt_int

From generic_equality.sail:

  • eq_anything
  • neq_anything

@tobiasgrosser tobiasgrosser added the Lean Issues with Sail to Lean translation label Feb 3, 2025
Copy link

github-actions bot commented Feb 3, 2025

Test Results

   12 files  ±0     25 suites  ±0   0s ⏱️ ±0s
  762 tests ±0    761 ✅  - 1  0 💤 ±0  0 ❌ ±0  1 🔥 +1 
2 706 runs  ±0  2 705 ✅  - 1  0 💤 ±0  0 ❌ ±0  1 🔥 +1 

For more details on these errors, see this check.

Results for commit 5c355b5. ± Comparison against base commit e4386bb.

♻️ This comment has been updated with latest results.

@tobiasgrosser
Copy link
Collaborator

Can you update the description of the PR to explain what it actually adds?

@benjaminselfridge benjaminselfridge changed the title Feature/lean external arith Adds several built-in SAIL functions (mostly arithmetic and equality) Feb 3, 2025
@benjaminselfridge benjaminselfridge changed the title Adds several built-in SAIL functions (mostly arithmetic and equality) Adds several Lean backends for built-in SAIL functions (mostly arithmetic and equality) Feb 3, 2025
@javra
Copy link
Collaborator

javra commented Feb 4, 2025

Can you add the extern.expected.sail? Then the CI will go 🟢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lean Issues with Sail to Lean translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants