Draft: alternative Orama search implementation #108
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use react
brookslybrand
force-pushed
the
brooks/orama-search
branch
from
845d3b7 to
2ed33c4
Compare
brookslybrand
force-pushed
the
brooks/orama-search
branch
from
2ed33c4 to
f8bd4c0
Compare
brookslybrand
commented
May 13, 2024
| @@ -0,0 +1,959 @@ | |||
| /*! @docsearch/css 3.5.2 | MIT License | © Algolia, Inc. and contributors | https://docsearch.algolia.com */ | |||
| return null; | ||
| } | ||
|
|
||
| // TODO: Need to implement onClose, otherwise it's impossible to make this a controlled component |
There was a problem hiding this comment.
I couldn't figure out a way to know when the onClose triggers, so the custom button can only be clicked 1 time 😕
Comment on lines
+84
to
+131
| export function SearchButton() { | ||
| let [, setShowSearchModal] = useSearchModal(); | ||
|
|
||
| let hydrated = useHydrated(); | ||
|
|
||
| if (!hydrated) { | ||
| // The Algolia doc search container is hard-coded at 40px. It doesn't | ||
| // render anything on the server, so we get a mis-match after hydration. | ||
| // This placeholder prevents layout shift when the search appears. | ||
| return <div className="h-10" />; | ||
| } | ||
|
|
||
| return ( | ||
| <> | ||
| <div className="animate-[fadeIn_100ms_ease-in_1]"> | ||
| <button | ||
| onClick={() => setShowSearchModal(true)} | ||
| type="button" | ||
| className="DocSearch DocSearch-Button" | ||
| aria-label="Search" | ||
| > | ||
| <span className="DocSearch-Button-Container"> | ||
| <svg | ||
| width="20" | ||
| height="20" | ||
| className="DocSearch-Search-Icon" | ||
| viewBox="0 0 20 20" | ||
| > | ||
| <path | ||
| d="M14.386 14.386l4.0877 4.0877-4.0877-4.0877c-2.9418 2.9419-7.7115 2.9419-10.6533 0-2.9419-2.9418-2.9419-7.7115 0-10.6533 2.9418-2.9419 7.7115-2.9419 10.6533 0 2.9419 2.9418 2.9419 7.7115 0 10.6533z" | ||
| stroke="currentColor" | ||
| fill="none" | ||
| fillRule="evenodd" | ||
| strokeLinecap="round" | ||
| strokeLinejoin="round" | ||
| ></path> | ||
| </svg> | ||
| <span className="DocSearch-Button-Placeholder">Search</span> | ||
| </span> | ||
| <span className="DocSearch-Button-Keys"> | ||
| <kbd className="DocSearch-Button-Key">⌘</kbd> | ||
| <kbd className="DocSearch-Button-Key">K</kbd> | ||
| </span> | ||
| </button> | ||
| </div> | ||
| </> | ||
| ); | ||
| } |
There was a problem hiding this comment.
I really don't love implementing this custom button and the context provider. Definitely wish I could style the orma button to just look like what we have, even if it's by using css class selectors like the DocSearch example we have
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#104