Handle main_dir in staging #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravwojdyla
force-pushed
the
rav-meta-artifact
branch
2 times, most recently
from
b34eac3 to
2fb8da1
Compare
ravwojdyla
force-pushed
the
rav-handle-main-dir
branch
2 times, most recently
from
dac38e4 to
84b1af7
Compare
ravwojdyla
force-pushed
the
rav-meta-artifact
branch
from
a9b2846 to
637fbdc
Compare
ravwojdyla
force-pushed
the
rav-handle-main-dir
branch
from
84b1af7 to
c76e616
Compare
ravwojdyla
force-pushed
the
rav-meta-artifact
branch
from
637fbdc to
915eefa
Compare
ravwojdyla
force-pushed
the
rav-handle-main-dir
branch
from
c76e616 to
7344d16
Compare
dhimmel
approved these changes
Apr 14, 2022
Comment on lines
+76
to
+78
| if self._file_prefix is not None: | ||
| return self._file_prefix | ||
| elif self.files_dir: |
There was a problem hiding this comment.
So _file_prefix is short for _staging_file_prefix, e.g. it's only set for staged artifacts? And files_dir is main_dir, but only for published artifacts?
Something to think about for the future... should the whole FSArtifact be refactored such that:
- main_dir (or files_dir... either name okay) holds the path to the staged artifact and then the published artifact
- a bool variable like
is_stagingindicates whether the artifact is still unpublished - files_pattern is relative to
main_dirand therefore doesn't need to be edited upon publication.
There was a problem hiding this comment.
So _file_prefix is short for _staging_file_prefix, e.g. it's only set for staged artifacts? And files_dir is main_dir, but only for published artifacts?
Yep.
Re refactor/future - def agree, there's a number of things I would like to refactor or add, but that probably won't happen anytime soon, not because I don't want to, but because it's not necessarily our priority right now. Linking to #5
ravwojdyla
force-pushed
the
rav-handle-main-dir
branch
from
7344d16 to
cdc6e60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #32