fix(analyzer): fix the issue that cannot get the glob pattern submodules' metadata. #288
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OS: windows 11
rustc: rustc 1.78.0 (9b00956e5 2024-04-29)
cargo: cargo 1.78.0 (54d8815d0 2024-03-26)
cargo-modules
version:Hi Vincent~
I pulled down the latest source code from
rust-lang/cargo
repo, and then execcargo modules structure
under its root directory, then I got the error:After debugged the
cargo-modules
sourcecode, I finally found that it due to failed to get the cargo metadata when the arg--manifest-path
's value is withVerbatim Disk prefix
.E.g.
After rose up a PR for the
rust-lang/cargo
repo, the owner notice me maybe it is the wrong invoking from thecargo-modules
.Due to the
glob
crate hadn't updated the semver yet for correctly get the sub paths fromglob(r"\\?\E:\Codes\Source\cargo\crates\*\Cargo.toml")
, maybe we'd better to not to use thecanonicalize
func to change the manifest path value on windows only~ 😉