Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(analyzer): fix the issue that cannot get the glob pattern submodules' metadata. #288

Merged

Conversation

wangziling
Copy link
Contributor

OS: windows 11
rustc: rustc 1.78.0 (9b00956e5 2024-04-29)
cargo: cargo 1.78.0 (54d8815d0 2024-03-26)

cargo-modules version:
image

Hi Vincent~

I pulled down the latest source code from rust-lang/cargo repo, and then exec cargo modules structure under its root directory, then I got the error:
image

After debugged the cargo-modules sourcecode, I finally found that it due to failed to get the cargo metadata when the arg --manifest-path's value is with Verbatim Disk prefix.
E.g.
image

After rose up a PR for the rust-lang/cargo repo, the owner notice me maybe it is the wrong invoking from the cargo-modules.

Due to the glob crate hadn't updated the semver yet for correctly get the sub paths from glob(r"\\?\E:\Codes\Source\cargo\crates\*\Cargo.toml"), maybe we'd better to not to use the canonicalize func to change the manifest path value on windows only~ 😉

@regexident regexident merged commit ebd74e5 into regexident:main May 20, 2024
8 checks passed
@regexident
Copy link
Owner

Thanks for this @wangziling!

@wangziling
Copy link
Contributor Author

Thanks for this @wangziling!

You are welcome~~~

Love this project😉.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants