Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use the latest rust-analyzer related crates, version 0.0.215. #286

Closed

Conversation

wangziling
Copy link
Contributor

Use the latest rust-analyzer related crates.

The enum ra_ap_project_model::ProjectWorkspace had been refactored at the version v0.0.212 against v0.0.211.

v0.0.211: https://docs.rs/ra_ap_project_model/0.0.211/ra_ap_project_model/enum.ProjectWorkspace.html
v0.0.212: https://docs.rs/ra_ap_project_model/0.0.212/ra_ap_project_model/struct.ProjectWorkspace.html

@wangziling
Copy link
Contributor Author

wangziling commented May 16, 2024

Seems here exists some clippy errors 😮.

Could I fix them by following the clippy's suggestions?

Seems the ToString impl check events are added from rust v1.78.0. 🤣.

@regexident
Copy link
Owner

Would you mind rebasing this onto main with linear history?

@wangziling wangziling closed this May 17, 2024
@wangziling
Copy link
Contributor Author

wangziling commented May 17, 2024

Would you mind rebasing this onto main with linear history?

let me create a new branch and new PR...

I don't know why it cannot process on rebase operation...

'Cause nearly I havn't used the rebase operation in the working life, I only used the merge operation('Cause we need to record the meaningful branch name with jira-or-something on the commit message).

So I'm afaid to forcibly do something with currently-unfamiliar rebase operation and let your main branch graph or history be chaos, so I decide to create a new branch which is checked out from the upstream/main and rise up a new PR.

I will deep dive into learning the rebase operation latter.

@wangziling wangziling deleted the features/update-dependencies branch May 20, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants