Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dead letter queue support #195

Merged
merged 5 commits into from
Oct 3, 2024
Merged

Add dead letter queue support #195

merged 5 commits into from
Oct 3, 2024

Conversation

agoncharov-reef
Copy link
Contributor

nuff said

Comment on lines 24 to 25
retries. The process of re-processing tasks is supposed to be manual,
thus there are no complicated mechanisms to prevent infinite loops.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we add a dead dead letter queue for this and then the fixing processor would be configured to pick stuff up from dead_letter and run it but on failure put in dead_dead_letter, then if this happens you can fix the code in such a way that it's not sending anything to dead_dead, run through the whole dead and finally run like a special task which takes everything from dead_dead and moves to dead or runs on dead_dead and puts to dead? I doubt we'll always be perfect and there isn't anything that would warn us about the infinite loop, so putting in a process to handle it properly seems practical to me. It's a good moment to think about how to handle it.

Also this sounds like something that should be described somewhere in the documentation of our framework, not just in this docstring here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just added a command to move tasks from one queue to another. No infinite loops involved.

322fc5e

@agoncharov-reef agoncharov-reef merged commit e5c44ba into master Oct 3, 2024
5 checks passed
@agoncharov-reef agoncharov-reef deleted the dead-letter-queue branch October 3, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants