Remove the format step from github ci workflow #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lint step already checks for formatting errors. By running the format step before lint step, the source is being properly formatted. So the lint step is unable to find the formatting problems (just formatted in the previous step).
mjurbanski-reef
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lint step already checks for formatting errors. By running the format step before lint step, the source is being properly formatted. So the lint step is unable to find the formatting problems (just formatted in the previous step).
I was confused, when locally nox -s lint failed with formatting errors, but github actions didn't!
Fun fact: this repo's workflow file has it correct. But the template workflow file does not.