Extract folder scanning module #212
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppolewicz
reviewed
May 18, 2022
| @@ -14,7 +14,7 @@ | |||
| EnvironmentEncodingError, | |||
| InvalidArgument, | |||
| IncompleteSync, | |||
| UnSyncableFilename, | |||
| UnsupportedFilename, | |||
There was a problem hiding this comment.
there should be a v2 test which makes sure we return UnSyncableFilename in v2
| @@ -447,8 +447,8 @@ def test_multiple_versions(self): | |||
|
|
|||
| self.assertEqual( | |||
| [ | |||
| "B2SyncPath(inner/a.txt, [('a2', 2000, 'upload'), ('a1', 1000, 'upload')])", | |||
| "B2SyncPath(inner/b.txt, [('b2', 1999, 'upload'), ('b1', 1001, 'upload')])" | |||
| "B2Path(inner/a.txt, [('a2', 2000, 'upload'), ('a1', 1000, 'upload')])", | |||
There was a problem hiding this comment.
I think it should be kept for v0, v1 and v2
| from b2sdk.scan.folder import AbstractFolder | ||
| from b2sdk.scan.folder import B2Folder | ||
| from b2sdk.scan.folder import LocalFolder | ||
| from b2sdk.scan.folder_parser import parse_folder |
There was a problem hiding this comment.
I think in v2 both parse_sync_folder and parse_folder should be available and there should be a test that makes sure we have it
Co-authored-by: Paweł Polewicz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure about this.
B2PathandB2SyncPathare aliases, but string representation changed, is it a backwards-incompatible change?