Support libc++ 19 #173
Merged
Support libc++ 19 #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rockwotj
commented
Feb 19, 2025
rockwotj
commented
- net: use std::span instead of std::string_view
- sstring: compare using raw pointers
- ossl: use raw pointer instead of iterator
- log: use pointer instead of iterator
In recent libcpp versions std::string_view and std::string cannot use `unsigned char` anymore.
In newer libcpp std::string_view iterator uses a wrapped type that is not comparable with `const char*`.
rockwotj
force-pushed
the
libcpp-fork
branch
from
7230bf9 to
95b6b91
Compare
rockwotj
requested review from
dotnwat,
travisdowns,
mmaslankaprv and
michael-redpanda
|
This brings scylladb#2649 to this repo and adds in fixes for our OpenSSL bits. |
dotnwat
approved these changes
Feb 19, 2025
|
FYI @michael-redpanda it would be great if you could apply 2011e15 to your upstream OpenSSL PR when you next go to update it. |
|
Thanks, LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.