consumer: combine offset map from multiple partially successful replies #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bashtanov
requested review from
bharathv,
nvartolomei,
ztlpn and
mmaslankaprv
nvartolomei
reviewed
Oct 22, 2024
nvartolomei
reviewed
Oct 22, 2024
| for i := 0; i < int(nPartitions); i++ { | ||
| if result[i].err == nil { | ||
| if !haveResult[i] { | ||
| seenPartitions += 1 |
There was a problem hiding this comment.
you are incrementing seenPartitions only when "result[i] is not error" this means that this method will succeed only after you get a complete successful result which is the same behavior as before from what i read
you are also incrementing seenPartitions only when you get the result for the first time so it won't ever actually succeed if there is at least one partial failure. seenPartitions == nPartitions won't ever be true in that case
If the number of partitions is high and leadership transfers happen often we may be unable to get a single all-successful result for a long time. Instead, combine a full result out of tolerate partially successful ones.
bashtanov
force-pushed
the
combine-offset-results
branch
from
c2fbce4 to
237efd0
Compare
mmaslankaprv
approved these changes
Oct 23, 2024
nvartolomei
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the number of partitions is high and leadership transfers happen often we may be unable to get a single all-successful result for a long time. Instead, combine a full result out of tolerate partially successful ones.