Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caution users that they must reduce replica count by 1 when scaling in #963

Merged
merged 13 commits into from
Jan 28, 2025

Conversation

JakeSCahill
Copy link
Contributor

@JakeSCahill JakeSCahill commented Jan 23, 2025

@JakeSCahill JakeSCahill requested a review from a team as a code owner January 23, 2025 10:37
Copy link

netlify bot commented Jan 23, 2025

Deploy Preview for redpanda-docs-preview ready!

Name Link
🔨 Latest commit bdbb24b
🔍 Latest deploy log https://app.netlify.com/sites/redpanda-docs-preview/deploys/6798b8e1a702e30008aab388
😎 Deploy Preview https://deploy-preview-963--redpanda-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JakeSCahill JakeSCahill requested a review from david-yu January 24, 2025 10:43
The Decommission controller is responsible for monitoring the StatefulSet for changes in the number replicas. When the number of replicas is reduced, the controller decommissions brokers, starting from the highest Pod ordinal, until the number of brokers matches the number of replicas. For example, you have a Redpanda cluster with the following brokers:
The Decommission controller is responsible for monitoring the StatefulSet for changes in the number replicas. When the number of replicas is reduced, the controller decommissions brokers, starting from the highest Pod ordinal, until the number of brokers matches the number of replicas.

[mermaid]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why you want the workflow to be aligned on the side of the legend rather than underneath?

Copy link
Contributor

@david-yu david-yu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thank you!


- For each Redpanda Pod on that Node, it identifies the PVC (if any) the Pod was using for its storage.
- It sets the reclaim policy of the affected PersistentVolume (PV) to `Retain`.
- It deletes the associated PersistentVolumeClaim (PVC) to allows the Redpanda broker Pod to reschedule onto a new, operational node.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- It deletes the associated PersistentVolumeClaim (PVC) to allows the Redpanda broker Pod to reschedule onto a new, operational node.
- It deletes the associated PersistentVolumeClaim (PVC) to allow the Redpanda broker Pod to reschedule onto a new, operational node.

== Prerequisites

- An existing Redpanda cluster in Kubernetes.
- Sufficient RBAC permissions for Nodewatcher to read and modify PVs, PVCs, and Node resources.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link to RBAC doc?

----
+
- `--additional-controllers="nodeWatcher"`: Enables the Nodewatcher controller.
- `rbac.createAdditionalControllerCRs=true`: Creates the required RBAC rules for the Redpanda Operator to monitor the Node resources and update PVCs and PVs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `rbac.createAdditionalControllerCRs=true`: Creates the required RBAC rules for the Redpanda Operator to monitor the Node resources and update PVCs and PVs.
- `--rbac.createAdditionalControllerCRs=true`: Creates the required RBAC rules for the Redpanda Operator to monitor the Node resources and update PVCs and PVs.

Copy link
Contributor

@Feediver1 Feediver1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try to remedy the diagram issue flagged below.

@JakeSCahill JakeSCahill merged commit 4ea8ab4 into main Jan 28, 2025
7 checks passed
@JakeSCahill JakeSCahill deleted the decom branch January 28, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants