Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC-884 Update recommendations for Pod resource management #946

Merged
merged 10 commits into from
Feb 7, 2025

Conversation

JakeSCahill
Copy link
Contributor

@JakeSCahill JakeSCahill commented Jan 15, 2025

Description

Resolves https://github.com/redpanda-data/documentation-private/issues/
Review deadline: 17 Jan

The new advice is to rely on K8s resource requests and limits.

Related PR: redpanda-data/helm-charts#1622

Page previews

https://deploy-preview-946--redpanda-docs-preview.netlify.app/current/manage/kubernetes/k-manage-resources/#memory

Checks

  • New feature
  • Content gap
  • Support Follow-up
  • Small fix (typos, links, copyedits, etc)

The new advice is to rely on K8s resource requests and limits
@JakeSCahill JakeSCahill requested a review from chrisseto January 15, 2025 16:22
@JakeSCahill JakeSCahill requested a review from a team as a code owner January 15, 2025 16:22
Copy link

netlify bot commented Jan 15, 2025

Deploy Preview for redpanda-docs-preview ready!

Name Link
🔨 Latest commit 2a50015
🔍 Latest deploy log https://app.netlify.com/sites/redpanda-docs-preview/deploys/6787e0cf1823d8000856d5b9
😎 Deploy Preview https://deploy-preview-946--redpanda-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 15, 2025

Deploy Preview for redpanda-docs-preview ready!

Name Link
🔨 Latest commit cf57444
🔍 Latest deploy log https://app.netlify.com/sites/redpanda-docs-preview/deploys/67a5eba29570bb0008160066
😎 Deploy Preview https://deploy-preview-946--redpanda-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JakeSCahill JakeSCahill changed the title Update recommendations for Pod resource management DOC-884 Update recommendations for Pod resource management Jan 16, 2025
@JakeSCahill JakeSCahill requested a review from chrisseto January 20, 2025 15:54
Copy link
Contributor

@chrisseto chrisseto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry if the switcharoo on the memory locking and overprovisioned configs caused the scope to increase on this a bit. I was hoping to streamline configuration management a bit.

@JakeSCahill
Copy link
Contributor Author

Thanks @chrisseto ! I've adapted all the examples to use the usual bare-metal flags with additionalRedpandaCmdFlags in favor of K8s-specific stanzas.

I've also clarified all the points you mentioned.

I took the description of --reserve-memory from the code comments in the CRD.

@JakeSCahill JakeSCahill requested a review from chrisseto January 24, 2025 17:11
Copy link
Contributor

@Feediver1 Feediver1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

JakeSCahill and others added 2 commits February 6, 2025 14:52
Copy link
Contributor

@chrisseto chrisseto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No hard blockers. I appreciate the depth you've gone to!

modules/manage/pages/kubernetes/k-manage-resources.adoc Outdated Show resolved Hide resolved
modules/manage/pages/kubernetes/k-manage-resources.adoc Outdated Show resolved Hide resolved
modules/manage/pages/kubernetes/k-manage-resources.adoc Outdated Show resolved Hide resolved
modules/manage/pages/kubernetes/k-manage-resources.adoc Outdated Show resolved Hide resolved
modules/manage/pages/kubernetes/k-manage-resources.adoc Outdated Show resolved Hide resolved
@JakeSCahill JakeSCahill merged commit fc195d5 into main Feb 7, 2025
7 checks passed
@JakeSCahill JakeSCahill deleted the pod-resource-mgmt branch February 7, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants