Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add osx support #65

Merged
merged 1 commit into from
Feb 25, 2025
Merged

feat: add osx support #65

merged 1 commit into from
Feb 25, 2025

Conversation

philippeboyd
Copy link
Contributor

@philippeboyd philippeboyd commented Jan 29, 2025

Closes #63

This adds support to build the library on OSX.

Also revamps the CI to build on multiple OS and Redis versions at the same time.

image

@moticless
Copy link
Collaborator

Hi @philippeboyd,
Thanks for the contribution! I'll review the PR over the weekend.
One quick thought: do we really need to test against 3 Ubuntu versions?

@philippeboyd
Copy link
Contributor Author

Hi @moticless, the only reason I build against all "current" Ubuntu versions is because the version of clang varies depending on the distro. But if you think that's overkill, I can surely just test against the latest ubuntu only. Let me know :)

20.04

clang version 10.0.0-4ubuntu1
Target: aarch64-unknown-linux-gnu
Thread model: posix
InstalledDir: /usr/bin

22.04

Ubuntu clang version 14.0.0-1ubuntu1.1
Target: aarch64-unknown-linux-gnu
Thread model: posix
InstalledDir: /usr/bin

24.04

Ubuntu clang version 18.1.3 (1ubuntu1)
Target: aarch64-unknown-linux-gnu
Thread model: posix
InstalledDir: /usr/bin

@moticless
Copy link
Collaborator

I think it’s redundant unless we bumped into a specific issue around it. More importantly, it seems GCC is no longer implicitly tested in the 'build' job as it was before.

@philippeboyd philippeboyd force-pushed the bugfix/fix-ci branch 2 times, most recently from b09c668 to 34a640e Compare February 7, 2025 03:56
@philippeboyd philippeboyd marked this pull request as ready for review February 7, 2025 04:01
@philippeboyd philippeboyd force-pushed the bugfix/fix-ci branch 3 times, most recently from 82b22a8 to 3131106 Compare February 7, 2025 05:28
@moticless
Copy link
Collaborator

Hey @philippeboyd,
is everything set with this PR?

@philippeboyd
Copy link
Contributor Author

Hey @philippeboyd, is everything set with this PR?

Yes, the CI github action looks good and tests everything on Linux and OSX 👍 I think we can go from here!

@moticless moticless merged commit 85c5539 into redis:main Feb 25, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compilation errors on OSX and Ubuntu 24.04
2 participants