Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vale-issue-695: Added IBM names to suggestattrib. file #696

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

dfitzmau
Copy link
Contributor

PR addresss #695

Copy link

Click here to review and test in web IDE: Contribute

Copy link

github-actions bot commented Nov 27, 2023

⚡️ Deploying PR Preview...

@dfitzmau dfitzmau force-pushed the vale-issue-695 branch 2 times, most recently from e159801 to f0da695 Compare November 27, 2023 15:56
Copy link
Member

@aireilly aireilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please escape the paren characters. Also, can you alpha sort the list of terms.

@dfitzmau dfitzmau force-pushed the vale-issue-695 branch 19 times, most recently from 4cfa600 to eba9994 Compare December 6, 2023 11:18
@aireilly
Copy link
Member

@dfitzmau can you update and get this one merged?

@dfitzmau
Copy link
Contributor Author

@dfitzmau can you update and get this one merged?

Hi @aireilly . I'll revisit post-GA but I hit some technical issues with it.

Copy link
Member

@aireilly aireilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@aireilly aireilly merged commit 045b53b into redhat-documentation:main Jun 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants