Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add basic support for declaring schema with inline $schema #970

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented May 17, 2024

What does this PR do?

  • adds basic support for $schema
    • this has second priority
      • # yaml-language-server $schema=
      • this feature
      • customSchemaProvider

What issues does this PR fix or reference?

Is it tested? How?

  • test/fixtures/sample-dollar-schema.json added
  • test/schema.test.ts
    • the modeline test is updated to include a $schema (which it ignores)
    • a new test is added which only provides a $schema (which beats settings)

@bollwyvl bollwyvl force-pushed the gh-964-use-dollar-schema branch from d40208e to 6767a56 Compare May 17, 2024 14:56
@coveralls
Copy link

coveralls commented May 17, 2024

Coverage Status

coverage: 84.248% (+0.07%) from 84.174%
when pulling b29478a on bollwyvl:gh-964-use-dollar-schema
into f039273 on redhat-developer:main.

@bollwyvl bollwyvl force-pushed the gh-964-use-dollar-schema branch from 940bc69 to 3c155e8 Compare May 17, 2024 16:32
@bollwyvl bollwyvl force-pushed the gh-964-use-dollar-schema branch from 3c155e8 to 1f7c659 Compare May 17, 2024 17:01
@bollwyvl bollwyvl marked this pull request as ready for review May 17, 2024 17:07
@bollwyvl
Copy link
Contributor Author

Looking more through older PRs and issues:

it appears some of the relevant argument there was in somehow ignoring $schema in additionalProperties... this PR doesn't propose anything like that, and the # yls modeline or by configuration would indeed be the only way in such a case.

@bollwyvl
Copy link
Contributor Author

I see 1.15.0 went out 🎉... what can I do to help this get into the review pipeline, and hopefully make it into the next release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants