add missing field descriptions for anyOf #1007
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ytausch build is failing and please fix the lint issues |
ytausch
force-pushed
the
anyof-parent-descriptions
branch
from
90ddd5b to
49f1ab4
Compare
|
@msivasubramaniaan done, could you please approve the workflow again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Currently, descriptions directly associated with anyOf fields are not shown when hovering. This PR ensures that descriptions for anyOf fields do not only show the descriptions of their children but also the parent description.
What issues does this PR fix or reference?
fixes #952
Is it tested? How?
Yes, please see the modified unit test files.