Fix code scanning alert no. 13: Shell command built from environment values #4698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…values Fixes: https://github.com/redhat-developer/vscode-openshift-tools/security/code-scanning/13 Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
vrubezhny
force-pushed
the
alert-autofix-13
branch
from
5f09756 to
b61cd1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/redhat-developer/vscode-openshift-tools/security/code-scanning/13
To fix the problem, we should avoid constructing the shell command as a single string and instead use
cp.execFileSyncto pass the command and its arguments separately. This approach ensures that the shell does not misinterpret any special characters in the environment values.Specifically, we need to:
cp.execSyncwithcp.execFileSync.Suggested fixes powered by Copilot Autofix. Review carefully before merging.