Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Bind Service" feature due to the deprecation of the Service Binding Operator #4682 #4681

Conversation

vrubezhny
Copy link
Contributor

@vrubezhny vrubezhny commented Dec 2, 2024

Issue: #4682

@vrubezhny vrubezhny marked this pull request as draft December 2, 2024 20:36
@vrubezhny vrubezhny force-pushed the fix-configure-cluster-cnpg-in-continuous-integration-workflow branch 4 times, most recently from 0c77b7d to 8b160f1 Compare December 2, 2024 23:38
@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 44.66%. Comparing base (da60441) to head (0c76878).
Report is 707 commits behind head on main.

Files with missing lines Patch % Lines
src/helm/helm.ts 66.66% 1 Missing ⚠️
src/oc/ocWrapper.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4681       +/-   ##
===========================================
+ Coverage   32.37%   44.66%   +12.28%     
===========================================
  Files          85       99       +14     
  Lines        6505     8110     +1605     
  Branches     1349     1722      +373     
===========================================
+ Hits         2106     3622     +1516     
- Misses       4399     4488       +89     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vrubezhny vrubezhny force-pushed the fix-configure-cluster-cnpg-in-continuous-integration-workflow branch 3 times, most recently from be2c0f5 to 6f3dae7 Compare December 3, 2024 21:44
@vrubezhny vrubezhny changed the title [build] Fix Cloud Native PostgreSQL operator installation Remove "Bind Service" feature due to the deprecation of the Service Binding Operator #4682 Dec 3, 2024
@vrubezhny vrubezhny marked this pull request as ready for review December 3, 2024 22:28
@vrubezhny vrubezhny requested a review from datho7561 December 3, 2024 22:28
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to me that the "Create Service Binding" feature has been removed properly. I left a few comments about some error popups that you are outputting.

src/helm/helm.ts Outdated Show resolved Hide resolved
src/oc/ocWrapper.ts Show resolved Hide resolved
src/oc/ocWrapper.ts Outdated Show resolved Hide resolved
@vrubezhny vrubezhny force-pushed the fix-configure-cluster-cnpg-in-continuous-integration-workflow branch from 6f3dae7 to b743b7e Compare December 3, 2024 23:41
@vrubezhny vrubezhny force-pushed the fix-configure-cluster-cnpg-in-continuous-integration-workflow branch from b743b7e to 0c76878 Compare December 4, 2024 12:48
@vrubezhny vrubezhny requested a review from datho7561 December 4, 2024 13:04
@vrubezhny
Copy link
Contributor Author

@datho7561 Thanks!

@vrubezhny vrubezhny merged commit 820b302 into redhat-developer:main Dec 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants