-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix create service webview #3435
Fix create service webview #3435
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3435 +/- ##
==========================================
- Coverage 35.43% 35.10% -0.34%
==========================================
Files 79 78 -1
Lines 5613 5629 +16
Branches 1116 1113 -3
==========================================
- Hits 1989 1976 -13
- Misses 3624 3653 +29
☔ View full report in Codecov by Sentry. |
4eeb5b0
to
2bc907d
Compare
new-create-service-demo.mp4Here is a demo. In this demo, I first use "Create Operator-backed Service" while logged in as "kubeadmin". As kubeadmin, I have access to the JSON schemas for CustomResourceDefinitions (CRDs). This means I can generate a form to specify the required information to create the service. In most non-OpenShift clusters that are designed to run on your development machine (such as k3s, minikube, kind), you can access the CRDs by default. After I have created a MongoDB instance using the kubeadmin account, I log in as "developer". I go through the same steps to create a new MongoDB instance, but instead of a form, I am given a YAML document containing the example YAML for the MongoDB CRD. This is because the developer account for OpenShift Local, doesn't have access to the full JSON schema for the MongoDB CRD. I can use "Kubernetes: Create" or "OpenShift: Create" to create the instance of the service specified by the YAML, and can save the YAML for future use. |
- Move the create service button from the Kubernetes tree to the context menu for the cluster - Add a page to the wizard to select which CustomResourceDefinition (CRD) to create an instance of, in lieu of using the Kubernetes tree to select the CRD - Show the documentation for the Operator that corresponds with the CRD on this page, since many Operators require additional post-installation steps before their associated CRDs work as expected - Material UI 5 -ify the form page - Add a Patternfly-like collpase widget for displaying nested objects - Remove properties from the schema if they are not required and aren't configured in the example YAML - If the user doesn't have access to list CRDs, drop them into a YAML editor with the example YAML for the CRD - We used to try to scrape the schema for the CRD from the swagger definitions, but I removed this, since the schema in the swagger definitions is often missing many properties and requires further processing to get it to work with React JsonSchema Form Fixes redhat-developer#3081 Signed-off-by: David Thompson <[email protected]>
2bc907d
to
180f93d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #3081
Signed-off-by: David Thompson [email protected]