Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scrolling section in Welcome page #3407

Merged

Conversation

datho7561
Copy link
Contributor

Fixes #3384

Signed-off-by: David Thompson [email protected]

@datho7561
Copy link
Contributor Author

fix-scrolling-welcome-page.mp4

@datho7561
Copy link
Contributor Author

To replicate the bug, I set display scaling to 200% then zoomed in twice.

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (e8e97d3) 36.04% compared to head (e7c5947) 36.04%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3407   +/-   ##
=======================================
  Coverage   36.04%   36.04%           
=======================================
  Files          77       77           
  Lines        5549     5549           
  Branches     1068     1068           
=======================================
  Hits         2000     2000           
  Misses       3549     3549           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@msivasubramaniaan msivasubramaniaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@datho7561
Copy link
Contributor Author

Thanks for reviewing, Muthu!

@datho7561 datho7561 merged commit 7466bf1 into redhat-developer:main Oct 10, 2023
6 checks passed
@datho7561 datho7561 deleted the 3384-scrolling-on-welcome-page branch October 10, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Welcome page display broken when scrolling down
2 participants