Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Maven flag for updating artifacts from snapshot repositories. #3848

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

rgrunber
Copy link
Member

@rgrunber rgrunber commented Nov 7, 2024

  • With JDT-LS depending on static (eg. latest) repositories, the Tycho build system may end up using stale artifacts cached locally, even when newer ones exist.

- With JDT-LS depending on static (eg. latest) repositories, the Tycho
  build system may end up using stale artifacts cached locally, even
  when newer ones exist.

Signed-off-by: Roland Grunberg <[email protected]>
@rgrunber rgrunber added this to the End November 2024 milestone Nov 7, 2024
@rgrunber rgrunber requested a review from datho7561 November 7, 2024 19:15
@datho7561
Copy link
Contributor

datho7561 commented Nov 7, 2024

Is it also worth updating in the gulpfile? i.e.

diff --git a/gulpfile.js b/gulpfile.js
index b0ca41a..1bdd4ca 100644
--- a/gulpfile.js
+++ b/gulpfile.js
@@ -282,7 +282,7 @@ function download_server_fn(){
 
 function build_server_fn(){
 	fse.removeSync('./server');
-	cp.execSync(mvnw() + ' -Pserver-distro clean package -Declipse.jdt.ls.skipGradleChecksums', { cwd: server_dir, stdio: [0, 1, 2] });
+	cp.execSync(mvnw() + ' -Pserver-distro clean package -Declipse.jdt.ls.skipGradleChecksums -U ', { cwd: server_dir, stdio: [0, 1, 2] });
 	gulp.src(server_dir + '/org.eclipse.jdt.ls.product/distro/*.tar.gz', { encoding: false })
 		.pipe(decompress())
 		.pipe(gulp.dest('./server'));

(I was using this locally)

Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I think it would be nice to get this in soon so that we are shipping the latest changes from eclipse-jdt-core-incubator in the snapshots.

@rgrunber rgrunber merged commit 6292a4c into redhat-developer:master Nov 7, 2024
2 checks passed
@rgrunber rgrunber deleted the update-snapshots branch November 7, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants