Skip to content

Commit

Permalink
Lombok agent doesn't need to be configured if javac is enabled
Browse files Browse the repository at this point in the history
  • Loading branch information
snjeza committed Nov 27, 2024
1 parent 2f57115 commit e42ac5b
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions src/lombokSupport.ts
Original file line number Diff line number Diff line change
Expand Up @@ -83,14 +83,23 @@ export function addLombokParam(context: ExtensionContext, params: string[]) {
// Exclude user setting Lombok agent parameter
const reg = /-javaagent:.*[\\|/]lombok.*\.jar/;
const deleteIndex = [];
let hasIndexer = false;
for (let i = 0; i < params.length; i++) {
if (reg.test(params[i])) {
deleteIndex.push(i);
}
hasIndexer = params[i] === "-DSourceIndexer.DOM_BASED_INDEXER=true";
}
for (let i = deleteIndex.length - 1; i >= 0; i--) {
params.splice(deleteIndex[i], 1);
}
// https://github.com/redhat-developer/vscode-java/issues/3875
// Lombok agent doesn't need to be configured if
// java.jdt.ls.javac.enabled=on; java.completion.engine=dom; -DSourceIndexer.DOM_BASED_INDEXER=true
if (hasIndexer && "on" === vscode.workspace.getConfiguration().get("java.jdt.ls.javac.enabled")
&& "dom" === vscode.workspace.getConfiguration().get("java.completion.engine")) {
return;
}
// add -javaagent arg to support Lombok.
// use the extension's Lombok version by default.
isExtensionLombok = true;
Expand Down

0 comments on commit e42ac5b

Please sign in to comment.