Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugin(ocir): add backstage app to openshift-image-registry workspace #34

Merged
merged 1 commit into from
Nov 8, 2024
Merged

plugin(ocir): add backstage app to openshift-image-registry workspace #34

merged 1 commit into from
Nov 8, 2024

Conversation

debsmita1
Copy link
Member

Hey, I just made a Pull Request!

Resolves:

To start the app, run the following from workspaces/openshift-image-registry:

yarn install
yarn dev

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or Updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)

@debsmita1 debsmita1 requested a review from 04kash November 8, 2024 06:42
@debsmita1 debsmita1 force-pushed the fix-oir-dev branch 3 times, most recently from 134f3ef to 82287a6 Compare November 8, 2024 06:56
@debsmita1 debsmita1 changed the title plugin(ocir): add backstage app to workspace plugin(ocir): add backstage app to openshift-image-registry workspace Nov 8, 2024
@debsmita1 debsmita1 force-pushed the fix-oir-dev branch 2 times, most recently from 588998c to 08454df Compare November 8, 2024 12:12
christoph-jerolimov
christoph-jerolimov approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@christoph-jerolimov christoph-jerolimov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • dev page works fine
  • test app starts fine

I get a 401 Forbidden and no error in the UI, but that's not the goal of adding a backstage app. So let us merge this and fix that later.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Nov 8, 2024
@christoph-jerolimov christoph-jerolimov removed their assignment Nov 8, 2024
@christoph-jerolimov christoph-jerolimov merged commit ff9b91b into redhat-developer:main Nov 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christoph-jerolimov christoph-jerolimov christoph-jerolimov approved these changes

@04kash 04kash Awaiting requested review from 04kash

@divyanshiGupta divyanshiGupta Awaiting requested review from divyanshiGupta divyanshiGupta is a code owner

Assignees
No one assigned
Labels
lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@debsmita1 @christoph-jerolimov