-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(homepage): add support to incl. the user displayName in the header title and to add a local and world clock to the header #313
Merged
christoph-jerolimov
merged 1 commit into
redhat-developer:main
from
christoph-jerolimov:homepage-improve-header
Jan 24, 2025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Important This PR includes changes that affect public-facing API. Please ensure you are adding/updating documentation for new features or behavior. Changed Packages
|
christoph-jerolimov
force-pushed
the
homepage-improve-header
branch
from
January 22, 2025 20:45
b1c4453
to
ff705f4
Compare
christoph-jerolimov
changed the title
feat(homepage): add support to incl. the username in the header title and the local time and a worldclock to the header
feat(homepage): add support to incl. the user displayName in the header title and to add a local and world clock to the header
Jan 22, 2025
christoph-jerolimov
force-pushed
the
homepage-improve-header
branch
5 times, most recently
from
January 22, 2025 21:56
136d91e
to
cdb43b4
Compare
4 tasks
debsmita1
requested changes
Jan 24, 2025
christoph-jerolimov
force-pushed
the
homepage-improve-header
branch
from
January 24, 2025 11:54
cdb43b4
to
fe6cbc2
Compare
…er title and to add a local and world clock to the header Signed-off-by: Christoph Jerolimov <[email protected]>
christoph-jerolimov
force-pushed
the
homepage-improve-header
branch
from
January 24, 2025 13:40
fe6cbc2
to
40fd5d5
Compare
Quality Gate passedIssues Measures |
debsmita1
approved these changes
Jan 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
This PR includes improvements to address https://issues.redhat.com/browse/RHIDP-5601. It ...
displayName
from the user catalog entity) in the header title.WorldClock
card based on the Home pluginHeaderWorldClock
component to show additional clocks/timezones also in the home page content area.It also includes additional documentation and unit tests for some components.
For the reviewers
The expectation is that the default configuration looks like before. Neigther the default title is changed, not any new clocks or cards are shown by default.
You can read the updated techdocs via techdocs or here:
I used this command to install the plugin into my local rhdh:
And this configuration in my
app-config.local.yaml
:✔️ Checklist