Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(orchestrator):Improve abort #252

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

LiorSoffer
Copy link
Contributor

@LiorSoffer LiorSoffer commented Jan 7, 2025

resolve FLPATH-1987
image
image

@rhdh-gh-app
Copy link

rhdh-gh-app bot commented Jan 7, 2025

Changed Packages

Package Name Package Path Changeset Bump Current Version
@red-hat-developer-hub/backstage-plugin-orchestrator workspaces/orchestrator/plugins/orchestrator patch v2.5.1

@batzionb
Copy link
Contributor

batzionb commented Jan 7, 2025

@LiorSoffer
I think since we have the dialog we can show the error in the dialog
Also the message should say "abort failed" not "Running again failed"
@ShiranHi WDYT?

@batzionb
Copy link
Contributor

batzionb commented Jan 7, 2025

Since we are already on the task, can you please also fix the abort button in the page to look like
figma

@batzionb
Copy link
Contributor

batzionb commented Jan 7, 2025

please fix the following differences from figma of dialog:

  1. buttons should be on left and not on the right
  2. the info icon should be filled and aligned with text
  3. the messages in the content should be bold as well

@LiorSoffer
Copy link
Contributor Author

@ShiranHi what do you think of this for abort failure?
image
@batzionb

Signed-off-by: Lior Soffer <[email protected]>
@batzionb batzionb merged commit 00f0cea into redhat-developer:main Jan 7, 2025
7 checks passed
@LiorSoffer LiorSoffer deleted the improve-abort branch January 8, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants