feat(marketplace): Add Plugin installation status in marketplace plugin #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthikjeeyar
requested review from
christoph-jerolimov,
debsmita1 and
divyanshiGupta
as code owners
Changed Packages
|
karthikjeeyar
force-pushed
the
plugin-installation-status
branch
from
14bb02e to
ed894c6
Compare
karthikjeeyar
force-pushed
the
plugin-installation-status
branch
from
ed894c6 to
ab7d3dc
Compare
christoph-jerolimov
requested changes
Jan 7, 2025
There was a problem hiding this comment.
Awesome progress! Thanks a lot @karthikjeeyar.
I found anyway some small code recommendations: 😏
...gins/catalog-backend-module-marketplace/src/processors/StaticPluginInstallStatusProcessor.ts
Outdated
Show resolved
Hide resolved
workspaces/marketplace/plugins/catalog-backend-module-marketplace/src/module.ts
Outdated
Show resolved
Hide resolved
...ins/catalog-backend-module-marketplace/src/processors/DynamicPluginInstallStatusProcessor.ts
Outdated
Show resolved
Hide resolved
...ins/catalog-backend-module-marketplace/src/processors/DynamicPluginInstallStatusProcessor.ts
Outdated
Show resolved
Hide resolved
...gins/catalog-backend-module-marketplace/src/processors/StaticPluginInstallStatusProcessor.ts
Outdated
Show resolved
Hide resolved
...gins/catalog-backend-module-marketplace/src/processors/StaticPluginInstallStatusProcessor.ts
Outdated
Show resolved
Hide resolved
...gins/catalog-backend-module-marketplace/src/processors/StaticPluginInstallStatusProcessor.ts
Outdated
Show resolved
Hide resolved
...gins/catalog-backend-module-marketplace/src/processors/StaticPluginInstallStatusProcessor.ts
Outdated
Show resolved
Hide resolved
...gins/catalog-backend-module-marketplace/src/processors/StaticPluginInstallStatusProcessor.ts
Outdated
Show resolved
Hide resolved
karthikjeeyar
force-pushed
the
plugin-installation-status
branch
from
74cf4c1 to
154c69b
Compare
christoph-jerolimov
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
https://issues.redhat.com/browse/RHIDP-5327
https://issues.redhat.com/browse/RHIDP-5328
Description:
Add new processors to determine the install status of a plugin.
StaticPluginInstallStatusProcessor : This reads the package.json from
packages/appandpackages/backendworkspaces and node_modules to identify if a plugin is installed or not.DynamicPluginInstallStatusProcessor: This relies on the dynamic-plugin feature and
/api/scalprumcall to identify the installed plugin in the RHDH.Released all the maketplace frontend, backend, common, and catalog-backend-module-marketplace plugins 0.0.1
Screenshots:
Unit tests:
✔️ Checklist