Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugin(bulk-import): add backstage app to workspace #25

Merged
merged 1 commit into from
Nov 7, 2024
Merged

plugin(bulk-import): add backstage app to workspace #25

merged 1 commit into from
Nov 7, 2024

Conversation

debsmita1
Copy link
Member

Hey, I just made a Pull Request!

Resolves:

To start the app, run the following from workspaces/bulk-import:

yarn install
yarn dev

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or Updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)

@debsmita1 debsmita1 requested a review from rm3l as a code owner November 6, 2024 19:39
christoph-jerolimov
christoph-jerolimov requested changes Nov 6, 2024
View reviewed changes
Copy link
Member

@christoph-jerolimov christoph-jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's working, just some tiny change requests. It will allow me anyway to take a look into the other PRs.

workspaces/bulk-import/packages/app/package.json Outdated Show resolved Hide resolved
workspaces/bulk-import/packages/app/package.json Outdated Show resolved Hide resolved
workspaces/bulk-import/packages/app/src/App.tsx Outdated Show resolved Hide resolved
workspaces/bulk-import/packages/app/src/components/Root/Root.tsx Show resolved Hide resolved
workspaces/bulk-import/packages/app/e2e-tests/app.test.ts Outdated Show resolved Hide resolved
@christoph-jerolimov
Copy link
Member

christoph-jerolimov commented Nov 7, 2024 •
edited
Loading

The build is failing because of linting / prettier issues. I spent some time today to understand that myself and maybe this commands help:

# eslint
# check
yarn lint
# fix
yarn lint --fix

# prettier
# check
yarn prettier --check .
# fix
yarn prettier --write .

# repo lint
# check
yarn backstage-cli repo fix --check --publish
# fix
yarn backstage-cli repo fix --publish

@debsmita1 debsmita1 force-pushed the fix-dev-mode branch 6 times, most recently from 2dea2cc to 9b3133b Compare November 7, 2024 06:14
christoph-jerolimov
christoph-jerolimov approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@christoph-jerolimov christoph-jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Lgtm!

@04kash 04kash merged commit fe7fad5 into redhat-developer:main Nov 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@04kash 04kash 04kash approved these changes

@christoph-jerolimov christoph-jerolimov christoph-jerolimov approved these changes

@rm3l rm3l Awaiting requested review from rm3l rm3l is a code owner

@BethGriggs BethGriggs Awaiting requested review from BethGriggs

@nickboldt nickboldt Awaiting requested review from nickboldt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@debsmita1 @christoph-jerolimov @04kash