feat(global-header): implemented searchBar #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed Packages
|
christoph-jerolimov
requested changes
Jan 7, 2025
workspaces/global-header/plugins/global-header/src/utils/stringUtils.tsx
Outdated
Show resolved
Hide resolved
workspaces/global-header/plugins/global-header/src/components/SearchComponent/SearchBar.tsx
Outdated
Show resolved
Hide resolved
workspaces/global-header/plugins/global-header/src/components/SearchComponent/SearchBar.tsx
Outdated
Show resolved
Hide resolved
workspaces/global-header/plugins/global-header/src/components/SearchComponent/SearchBar.tsx
Show resolved
Hide resolved
| ), | ||
| }} | ||
| sx={{ | ||
| pt: '0.5rem', |
There was a problem hiding this comment.
For me, it feels like this padding-top breaks that the input field is vertically centered.
Suggested change
| pt: '0.5rem', |
There was a problem hiding this comment.
Without this padding top, it looks closer to the top instead of centered virtually.
With pt
What do you think? Maybe I can make it pt: '6px' which looks like
There was a problem hiding this comment.
To be honest, for me, the first one looks the best. 😏
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
ciiay
force-pushed
the
rhidp-5365-create-search-bar
branch
from
fd0df0a to
f910b22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
For RHIDP-5365
✔️ Checklist
screen recording
rhidp_5365.mp4