-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bulk-import): upgrading to mui5 #24
feat(bulk-import): upgrading to mui5 #24
Conversation
cc : @debsmita1 |
/cc @debsmita1 |
@its-mitesh-kumar To fix CI issues, you'd have to run |
workspaces/bulk-import/plugins/bulk-import/src/components/AddRepositories/AddRepositories.tsx
Show resolved
Hide resolved
Tested the changes locally, and the changes look fine |
@divyanshiGupta |
If we aren't using |
@divyanshiGupta ! With the below commit resize issue has gone . |
workspaces/bulk-import/packages/app/src/components/search/SearchPage.tsx
Outdated
Show resolved
Hide resolved
workspaces/bulk-import/plugins/bulk-import/src/components/AddRepositories/AddRepositories.tsx
Show resolved
Hide resolved
I still have the resize issue; it depends on how your OS renders the scrollbar. The issue is logged here in MUI: mui/material-ui#43718 (there are also multiple duplicates) For me, this issue appears only when multiple TextFields with the I think we can go ahead for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@christoph-jerolimov ! For me its looking like below . |
Don't understand how this is possible, but we can start merging and then we will take a look again. |
Resolves : https://issues.redhat.com/browse/RHIDP-4308