Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(openshift-image-registry): add missing CORS configuration to test plugin with the bundled backstage app #237

Merged

Conversation

christoph-jerolimov
Copy link
Member

@christoph-jerolimov christoph-jerolimov commented Jan 3, 2025

Hey, I just made a Pull Request!

I got CORS issues when the OpenShift Image registry plugin fetches information from a included backstage app.

This additional, default backstage configuration solves that problem.

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or Updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)

…st plugin with the bundled backstage app

Signed-off-by: Christoph Jerolimov <[email protected]>
Copy link
Member

@debsmita1 debsmita1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 6, 2025
@christoph-jerolimov christoph-jerolimov merged commit 54f2ca3 into redhat-developer:main Jan 6, 2025
7 checks passed
@christoph-jerolimov christoph-jerolimov deleted the fix-oir branch January 6, 2025 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants