-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update copyright header #235
Conversation
Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Changed Packages
|
82c62af
to
1ab533f
Compare
@@ -1,5 +1,5 @@ | |||
/* | |||
* Copyright 2024 The Backstage Authors | |||
* Copyright 2025 The RHDH Authors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this actually be a range of dates? eg., 2024-2025?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And when its okay, just another "idea": is RHDH Authors really a thing or should we go one step forward and say something like "Copyright 2024 Red Hat and contributors"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed it to Red Hat, Inc. based on the other copyright notices in the redhat-developer
org
Hey @04kash, I always wanted start a code-review with this words.. I'm not a lawyar 😄 but I think we should keep the first year we introduced the code, so 2024 in most cases here. It's nice that we update the author from backstage to RHDH for all code and the template to 2025. |
There is an interesting article titled
So I think we can maybe simplify and omit the year. |
Yup I agree omitting the date would make things easier! |
Signed-off-by: Kashish Mittal <[email protected]>
Signed-off-by: Kashish Mittal <[email protected]>
Signed-off-by: Kashish Mittal <[email protected]>
Signed-off-by: Kashish Mittal <[email protected]>
Signed-off-by: Kashish Mittal <[email protected]>
Signed-off-by: Kashish Mittal <[email protected]>
Signed-off-by: Kashish Mittal <[email protected]>
Signed-off-by: Kashish Mittal <[email protected]>
Signed-off-by: Kashish Mittal <[email protected]>
Signed-off-by: Kashish Mittal <[email protected]>
1ab533f
to
eb870b1
Compare
Signed-off-by: Kashish Mittal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
We have currently 20 other PRs, but it looks like most of them are version updates and bugfixes that doesn't introduce new files. There is just one feature PR opened today that needs to be updated anyway. I guess it's acceptable to merge this change right now and see how many PRs needs to be updated with this new (eslint) requirement. |
Hey, I just made a Pull Request!
This PR updates the copyright header template to accept copyright headers with either "The RHDH Authors" or "The Backstage" (since a lot of the workflows used in this repository are from backstage/community-plugins) as valid options.
The header files for the following workspaces are also updated in the PR: bulk-import, global-header, homepage, lightspeed, marketplace, openshift-image-registry, theme.
I will update the orchestrator workplace files in a separate PR as it has few eslint errors.
Fixes: https://issues.redhat.com/browse/RHIDP-5401
✔️ Checklist