feat(bulk-import): use react query to fetch repositories #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...paces/bulk-import/plugins/bulk-import/src/components/AddRepositories/AddRepositoriesForm.tsx
Outdated
Show resolved
Hide resolved
| }); | ||
| setOpenDrawer(false); | ||
| if (!mutationCreate.isError) { |
There was a problem hiding this comment.
I would expect that you need await mutate to see the error here. Also then I'm unsure if this error is automatically updated before the component is re-rendered. Did you tested the error case?
There was a problem hiding this comment.
The error scenario that I tested, the mutationCreate.isError returns the boolean value without the await
workspaces/bulk-import/plugins/bulk-import/src/hooks/useAddedRepositories.ts
Outdated
Show resolved
Hide resolved
workspaces/bulk-import/plugins/bulk-import/src/hooks/useRepositories.ts
Outdated
Show resolved
Hide resolved
debsmita1
force-pushed
the
bulk-import-reactQuery
branch
2 times, most recently
from
5c0f97b to
54e98c1
Compare
debsmita1
force-pushed
the
bulk-import-reactQuery
branch
from
54e98c1 to
bfffab3
Compare
debsmita1
force-pushed
the
bulk-import-reactQuery
branch
from
bfffab3 to
bc9d9cf
Compare
christoph-jerolimov
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
Resolves:
https://issues.redhat.com/browse/RHIDP-4035
✔️ Checklist