feat(bulk-import): update preview form to use separate formik context #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christoph-jerolimov
requested changes
Nov 6, 2024
There was a problem hiding this comment.
This looks really clean and good to me!
You decided now to have one form per tab but save the errors in the page formik state?
When I click on preview, change the PR information, press save, and reopen the drawer, it always shows the default data. Maybe I'm testing it wrong. We can check that together.
edit: That's also the case on the main branch, so I guess I misunderstood something here.
workspaces/bulk-import/plugins/bulk-import/src/utils/repository-utils.tsx
Outdated
Show resolved
Hide resolved
...s/bulk-import/plugins/bulk-import/src/components/PreviewFile/PreviewPullRequestForm.test.tsx
Outdated
Show resolved
Hide resolved
Yes, in this way I can track all the field errors in single form/multiple sub forms |
debsmita1
force-pushed
the
preview-pr
branch
3 times, most recently
from
4299242 to
aaa2d80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
Resolves:
https://issues.redhat.com/browse/RHIDP-3890
✔️ Checklist