chore: unify prettier to 3.4.2 #212
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mareklibra
requested review from
batzionb,
gciavarrini,
christoph-jerolimov,
ciiay,
debsmita1,
divyanshiGupta,
rm3l,
BethGriggs,
nickboldt,
kim-tsao and
04kash
as code owners
Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Changed Packages
|
batzionb
approved these changes
Dec 19, 2024
mareklibra
force-pushed
the
FLPATH-1960.gitCommitPrettier
branch
from
8673a9e to
ab8e255
Compare
mareklibra
force-pushed
the
FLPATH-1960.gitCommitPrettier
branch
from
ab8e255 to
b2797f4
Compare
christoph-jerolimov
requested changes
Dec 19, 2024
...paces/orchestrator/plugins/orchestrator-backend/static/generated/envelope/combined.bundle.js
Outdated
Show resolved
Hide resolved
...diagram/org.kie.workbench.common.stunner.sw.KogitoSWEditor/css/bootstrap-3.4.1.min.cache.css
Outdated
Show resolved
Hide resolved
workspaces/repo-tools/packages/cli/src/lib/workspaces/templates/workspace/.gitignore.hbs
Outdated
Show resolved
Hide resolved
...paces/orchestrator/plugins/orchestrator-backend/static/generated/envelope/combined.bundle.js
Outdated
Show resolved
Hide resolved
workspaces/repo-tools/packages/cli/src/lib/workspaces/templates/workspace/catalog-info.yaml.hbs
Outdated
Show resolved
Hide resolved
gciavarrini
requested changes
Dec 19, 2024
mareklibra
force-pushed
the
FLPATH-1960.gitCommitPrettier
branch
7 times, most recently
from
bb327d3 to
f3eda57
Compare
mareklibra
force-pushed
the
FLPATH-1960.gitCommitPrettier
branch
from
f3eda57 to
c657a3a
Compare
mareklibra
force-pushed
the
FLPATH-1960.gitCommitPrettier
branch
from
c657a3a to
91f9285
Compare
christoph-jerolimov
requested changes
Jan 6, 2025
There was a problem hiding this comment.
Hi @mareklibra, this looks much better now. But can you take a look into the root package.json and yarn.lock?
| @@ -15,25 +15,50 @@ | |||
| "type": "module", | |||
| "packageManager": "[email protected]", | |||
| "devDependencies": { | |||
| "@backstage/catalog-model": "^1.7.2", | |||
There was a problem hiding this comment.
I think we should not add this kind of dependencies to the root package.json
Comment on lines
+34
to
+37
| "axios": "^1.7.9", | ||
| "chalk": "^5.4.0", | ||
| "commander": "^12.1.0", | ||
| "cross-fetch": "^4.0.0", |
There was a problem hiding this comment.
Shouldn't be needed here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unifies prettier to a single 3.4.2 version through-out the whole repo.
Different prettier versions give different results on the same sources which is causing issues/confusion when switching between local dev and CI envs.
The first commit is result of a manual change, the later one is the result of calling the prettier from the root-level and then from every workspace.