Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightspeed: Upgrade pf chatbot version #165

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

karthikjeeyar
Copy link
Contributor

@karthikjeeyar karthikjeeyar commented Dec 12, 2024

Fixes

https://issues.redhat.com/browse/RHIDP-5164
https://issues.redhat.com/browse/RHDHPAI-474
https://issues.redhat.com/browse/RHDHPAI-481

Description

This PF chatbot upgrade fixes several issues which were previously handled on plugin level.

This PR contains following fixes

  • bullets and numbering format in the response
  • removed custom handling of dropdown toggle onclick delete action
  • "New chat" button and close buton order is reversed

Before:

lightspeed_response

After:

after_upgrade

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or Updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)

@rhdh-gh-app
Copy link

rhdh-gh-app bot commented Dec 12, 2024

Changed Packages

Package Name Package Path Changeset Bump Current Version
@red-hat-developer-hub/backstage-plugin-lightspeed workspaces/lightspeed/plugins/lightspeed patch v0.2.4

@karthikjeeyar karthikjeeyar force-pushed the upgrade-pf-chatbot branch 2 times, most recently from 6efbd94 to d70f0d1 Compare January 2, 2025 13:31
@Eswaraiahsapram
Copy link
Contributor

/lgtm

Copy link

openshift-ci bot commented Jan 6, 2025

@Eswaraiahsapram: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@yangcao77
Copy link
Contributor

@karthikjeeyar Do you mind rebase main before I approve this change?

@karthikjeeyar karthikjeeyar force-pushed the upgrade-pf-chatbot branch 2 times, most recently from c168619 to a4949e8 Compare January 7, 2025 13:25
@karthikjeeyar
Copy link
Contributor Author

@yangcao77 Rebased my PRs

@yangcao77
Copy link
Contributor

/lgtm

Copy link

openshift-ci bot commented Jan 7, 2025

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the lgtm label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants