Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightspeed: Persist last conversation state and reload on user revisit #159

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

karthikjeeyar
Copy link
Contributor

Fixes

https://issues.redhat.com/browse/RHDHPAI-380

Description

Persist last conversation and reload on user revisit

Screenshots

remember_last_conversation

Unit tests

  useLastOpenedConversation
    ✓ should not be ready when user is undefined (20 ms)
    ✓ should load the lastOpenedId from localStorage when user is provided (4 ms)
    ✓ should handle missing user data in localStorage (3 ms)
    ✓ should update localStorage when setLastOpenedId is called (3 ms)
    ✓ should clear lastOpenedId when clearLastOpenedId is called (2 ms)
    ✓ should not update localStorage if user is undefined (2 ms)
    ✓ should not clear localStorage if user is undefined

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or Updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)

@rhdh-gh-app
Copy link

rhdh-gh-app bot commented Dec 11, 2024

Changed Packages

Package Name Package Path Changeset Bump Current Version
@red-hat-developer-hub/backstage-plugin-lightspeed workspaces/lightspeed/plugins/lightspeed patch v0.2.4

@christoph-jerolimov christoph-jerolimov changed the title Persist last conversation state and reload on user revisit Lightspeed: Persist last conversation state and reload on user revisit Dec 14, 2024
@Eswaraiahsapram
Copy link
Contributor

/lgtm

Copy link

openshift-ci bot commented Jan 6, 2025

@Eswaraiahsapram: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@yangcao77
Copy link
Contributor

@karthikjeeyar Do you mind rebase main before I approve this change?

@karthikjeeyar karthikjeeyar assigned yangcao77 and unassigned yangcao77 Jan 7, 2025
@yangcao77
Copy link
Contributor

/lgtm

@karthikjeeyar karthikjeeyar force-pushed the remember-last-conversation branch from 2289fe0 to a2d5aa9 Compare January 7, 2025 15:09
@openshift-ci openshift-ci bot removed the lgtm label Jan 7, 2025
Copy link

openshift-ci bot commented Jan 7, 2025

New changes are detected. LGTM label has been removed.

Copy link
Contributor

@yangcao77 yangcao77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants