Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Check install and airgap scripts in CI [RHIDP 5162] #751

Conversation

rm3l
Copy link
Member

@rm3l rm3l commented Feb 5, 2025

Description

This introduces ShellCheck for checking our scripts (including the CI and airgap ones) in CI.
It leverages https://github.com/redhat-plumbers-in-action/differential-shellcheck

Which issue(s) does this PR fix or relate to

PR acceptance criteria

  • Tests
  • Documentation

How to test changes / Special notes to the reviewer

Copy link

openshift-ci bot commented Feb 5, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from rm3l. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ShellCheck found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@rm3l rm3l force-pushed the RHIDP-5162--static-analysis-checks-against-install-and-airgap-scripts branch from 33b5171 to 39eddaa Compare February 10, 2025 12:37
@rm3l rm3l changed the title wip: ci: Check install and airgap scripts in CI [RHIDP 5162] ci: Check install and airgap scripts in CI [RHIDP 5162] Feb 10, 2025
@rm3l rm3l marked this pull request as ready for review February 10, 2025 13:24
@openshift-ci openshift-ci bot requested review from kadel and kim-tsao February 10, 2025 13:24
@rm3l rm3l merged commit c2c282f into redhat-developer:main Feb 10, 2025
10 of 11 checks passed
@rm3l rm3l deleted the RHIDP-5162--static-analysis-checks-against-install-and-airgap-scripts branch February 10, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant