Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix issue preventing the bundle diff checker job from committing changes detected #625

Conversation

rm3l
Copy link
Member

@rm3l rm3l commented Jan 6, 2025

Description

Checking out the merge commit causes us to no longer be on the PR branch, as we can see in these logs [1].

[1] https://github.com/redhat-developer/rhdh-operator/actions/runs/12632058905/job/35222737737

Which issue(s) does this PR fix or relate to

This is to fix the CI issues detected in #622.

PR acceptance criteria

How to test changes / Special notes to the reviewer

…changes detected

Checking out the merge commit causes us to no longer be on the PR branch, as we can see in these logs [1]

[1] https://github.com/redhat-developer/rhdh-operator/actions/runs/12632058905/job/35222737737
Copy link

openshift-ci bot commented Jan 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rm3l rm3l merged commit 1f18ec9 into redhat-developer:main Jan 6, 2025
6 of 7 checks passed
@rm3l rm3l deleted the fix_issue_preventing_committing_bundle_changes_detected_in_pr branch January 6, 2025 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant