Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for exposing OpenTelemetry metrics #48

Merged
merged 3 commits into from
Nov 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/backstage/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -45,4 +45,4 @@ sources:
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 2.22.0
version: 2.23.0
2 changes: 1 addition & 1 deletion charts/backstage/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# RHDH Backstage Helm Chart for OpenShift (Community Version)

[![Artifact Hub](https://img.shields.io/endpoint?url=https://artifacthub.io/badge/repository/rhdh-chart&style=flat-square)](https://artifacthub.io/packages/search?repo=rhdh-chart)
![Version: 2.22.0](https://img.shields.io/badge/Version-2.22.0-informational?style=flat-square)
![Version: 2.23.0](https://img.shields.io/badge/Version-2.23.0-informational?style=flat-square)
![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square)

A Helm chart for deploying Red Hat Developer Hub.
Expand Down
10 changes: 8 additions & 2 deletions charts/backstage/values.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -6598,7 +6598,7 @@
"type": "integer"
}
],
"default": "http-backend",
"default": "http-metrics",
"description": "The port where the metrics are exposed. If using OpenTelemetry as [documented here](https://backstage.io/docs/tutorials/setup-opentelemetry/), then the port needs to be explicitely specificed. OpenTelemetry's default port is 9464.",
"title": "ServiceMonitor endpoint port"
}
Expand Down Expand Up @@ -7206,7 +7206,13 @@
"type": "string"
},
"extraPorts": {
"default": [],
"default": [
{
"name": "http-metrics",
"port": 9464,
"targetPort": 9464
}
],
"items": {
"type": "object"
},
Expand Down
14 changes: 12 additions & 2 deletions charts/backstage/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,13 @@ upstream:
checksum/dynamic-plugins: >-
{{- include "common.tplvalues.render" ( dict "value"
.Values.global.dynamic "context" $) | sha256sum }}
ingress:
host: "{{ .Values.global.host }}"
metrics:
serviceMonitor:
enabled: false
path: /metrics
port: http-metrics
postgresql:
enabled: true
postgresqlDataDir: /var/lib/pgsql/data/userdata
Expand Down Expand Up @@ -232,8 +239,11 @@ upstream:
secretKeyRef:
key: postgres-password
name: '{{- include "postgresql.v1.secretName" . }}'
ingress:
host: "{{ .Values.global.host }}"
service:
extraPorts:
- name: http-metrics
port: 9464
targetPort: 9464

# -- OpenShift Route parameters
route:
Expand Down
Loading