-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated plugin doc for Argo CD Rollouts feature #725
base: main
Are you sure you want to change the base?
Conversation
Updated preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-725/ @ 12/02/24 16:07:17 |
artifacts/rhdh-plugins-reference/argocd/argocd-plugin-admin.adoc
Outdated
Show resolved
Hide resolved
artifacts/rhdh-plugins-reference/argocd/argocd-plugin-admin.adoc
Outdated
Show resolved
Hide resolved
c15cf57
to
4bddf6e
Compare
4bddf6e
to
47bfe03
Compare
47bfe03
to
3d5f93b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM |
New changes are detected. LGTM label has been removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the content! A couple suggestions.
@@ -70,6 +70,143 @@ global: | |||
disabled: false | |||
---- | |||
|
|||
== (Optional) Enabling Argo CD Rollouts feature |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
== (Optional) Enabling Argo CD Rollouts feature | |
== Enabling Argo CD Rollouts |
@@ -70,6 +70,143 @@ global: | |||
disabled: false | |||
---- | |||
|
|||
== (Optional) Enabling Argo CD Rollouts feature | |||
|
|||
The Argo CD Rollouts feature enhances Kubernetes by providing advanced deployment strategies, such as blue-green and canary deployments, for your applications. When integrated into the backstage Kubernetes plugin, it allows developers and operations team to visualize and manage these Rollouts seamlessly within the Backstage interface. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Argo CD Rollouts feature enhances Kubernetes by providing advanced deployment strategies, such as blue-green and canary deployments, for your applications. When integrated into the backstage Kubernetes plugin, it allows developers and operations team to visualize and manage these Rollouts seamlessly within the Backstage interface. | |
The optional Argo CD Rollouts feature enhances Kubernetes by providing advanced deployment strategies, such as blue-green and canary deployments, for your applications. When integrated into the backstage Kubernetes plugin, it allows developers and operations teams to visualize and manage Argo CD Rollouts seamlessly within the Backstage interface. |
|
||
.Prerequisites | ||
|
||
* *Backstage Kubernetes plugin installed:* Verify that the Kubernetes plugin in Backstage (`@backstage/plugin-kubernetes`) is installed and configured. To install and configure Kubernetes plugin in Backstage, see link:https://backstage.io/docs/features/kubernetes/installation/[Installaltion] and link:https://backstage.io/docs/features/kubernetes/configuration/[Configuration] guide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* *Backstage Kubernetes plugin installed:* Verify that the Kubernetes plugin in Backstage (`@backstage/plugin-kubernetes`) is installed and configured. To install and configure Kubernetes plugin in Backstage, see link:https://backstage.io/docs/features/kubernetes/installation/[Installaltion] and link:https://backstage.io/docs/features/kubernetes/configuration/[Configuration] guide. | |
* The Backstage Kubernetes plugin (`@backstage/plugin-kubernetes`) is installed and configured. | |
** To install and configure a Kubernetes plugin in Backstage, see the link:https://backstage.io/docs/features/kubernetes/installation/[Installaltion] and link:https://backstage.io/docs/features/kubernetes/configuration/[Configuration] guides. |
|
||
* *Backstage Kubernetes plugin installed:* Verify that the Kubernetes plugin in Backstage (`@backstage/plugin-kubernetes`) is installed and configured. To install and configure Kubernetes plugin in Backstage, see link:https://backstage.io/docs/features/kubernetes/installation/[Installaltion] and link:https://backstage.io/docs/features/kubernetes/configuration/[Configuration] guide. | ||
|
||
* *Kubernetes cluster access:* Ensure you have access to the Kubernetes cluster with the necessary permissions to create and manage custom resources and `ClusterRoles`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* *Kubernetes cluster access:* Ensure you have access to the Kubernetes cluster with the necessary permissions to create and manage custom resources and `ClusterRoles`. | |
* You have access to the Kubernetes cluster with the necessary permissions to create and manage custom resources and `ClusterRoles`. |
|
||
* *Kubernetes cluster access:* Ensure you have access to the Kubernetes cluster with the necessary permissions to create and manage custom resources and `ClusterRoles`. | ||
|
||
* *Argo Rollouts resources:* Confirm that the Kubernetes cluster has the `argoproj.io` group resources (for example, Rollouts and AnalysisRuns) installed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* *Argo Rollouts resources:* Confirm that the Kubernetes cluster has the `argoproj.io` group resources (for example, Rollouts and AnalysisRuns) installed. | |
* The Kubernetes cluster has the `argoproj.io` group resources (for example, Rollouts and AnalysisRuns) installed. |
. Update `app-config.yaml` for custom resources. | ||
|
||
.. Open the `app-config.yaml` file in your Backstage instance. | ||
|
||
.. Add the following `customResources` component under the `kubernetes` configuration to enable Argo Rollouts and AnalysisRuns: | ||
+ | ||
[source,yaml] | ||
---- | ||
kubernetes: | ||
... | ||
customResources: | ||
- group: 'argoproj.io' | ||
apiVersion: 'v1alpha1' | ||
plural: 'Rollouts' | ||
- group: 'argoproj.io' | ||
apiVersion: 'v1alpha1' | ||
plural: 'analysisruns' | ||
---- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
. Update `app-config.yaml` for custom resources. | |
.. Open the `app-config.yaml` file in your Backstage instance. | |
.. Add the following `customResources` component under the `kubernetes` configuration to enable Argo Rollouts and AnalysisRuns: | |
+ | |
[source,yaml] | |
---- | |
kubernetes: | |
... | |
customResources: | |
- group: 'argoproj.io' | |
apiVersion: 'v1alpha1' | |
plural: 'Rollouts' | |
- group: 'argoproj.io' | |
apiVersion: 'v1alpha1' | |
plural: 'analysisruns' | |
---- | |
. In the `app-config.yaml` file in your Backstage instance, add the following `customResources` component under the `kubernetes` configuration to enable Argo Rollouts and AnalysisRuns: | |
+ | |
[source,yaml] | |
---- | |
kubernetes: | |
... | |
customResources: | |
- group: 'argoproj.io' | |
apiVersion: 'v1alpha1' | |
plural: 'Rollouts' | |
- group: 'argoproj.io' | |
apiVersion: 'v1alpha1' | |
plural: 'analysisruns' | |
---- |
|
||
. Grant `ClusterRole` permissions for custom resources. | ||
|
||
.. Verify whether the Backstage Kubernetes plugin is already configured. If it is, the `ClusterRole` for Rollouts and AnalysisRuns might already be granted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.. Verify whether the Backstage Kubernetes plugin is already configured. If it is, the `ClusterRole` for Rollouts and AnalysisRuns might already be granted. | |
.. If the Backstage Kubernetes plugin is already configured, the `ClusterRole` permission for Rollouts and AnalysisRuns might already be granted. |
Use a link:https://raw.githubusercontent.com/backstage/community-plugins/main/workspaces/redhat-argocd/plugins/argocd/manifests/clusterrole.yaml[prepared manifest] for a read-only `ClusterRole` that provides access for both the Kubernetes plugin and the ArgoCD plugin. | ||
==== | ||
|
||
.. If not already granted, use the following YAML manifest to create the ClusterRole: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.. If not already granted, use the following YAML manifest to create the ClusterRole: | |
.. If the `ClusterRole` permission is not already granted, use the following YAML manifest to create the ClusterRole: |
should the second instance of ClusterRole also be formatted as ClusterRole
?
backstage.io/kubernetes-namespace: <RESOURCE_NAMESPACE> | ||
---- | ||
|
||
.. For using custom label selectors (takes precedence over the above annotations): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technical documentation generally strives to avoid the use of "pointing language", such as "above." Consider replacing "above annotations" with the actual annotations you are referring to. This also prevents users from having to scroll back up to see what you are referencing "above".
. Confirm that: | ||
|
||
** Kubernetes resources, such as Rollouts and AnalysisRuns, are visible under the *Kubernetes* tab. | ||
|
||
** The Argo CD Rollouts feature is functioning as expected, allowing you to monitor rollouts status and manage deployments. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
. Confirm that: | |
** Kubernetes resources, such as Rollouts and AnalysisRuns, are visible under the *Kubernetes* tab. | |
** The Argo CD Rollouts feature is functioning as expected, allowing you to monitor rollouts status and manage deployments. | |
. Confirm that the Argo CD Rollouts feature is functioning as expected by performing the following checks: | |
** Kubernetes resources, such as Rollouts and AnalysisRuns, are visible under the *Kubernetes* tab. | |
** You are able to effectively monitor rollouts status and manage deployments. | |
IMPORTANT: Do Not Merge - To be merged by Docs Team Only
In this PR:
Version(s): RHDH 1.4 and RHTAP 1.3
Issue:
HACDOCS-1157
Output: