fix: support pushing image to any openshift internal registry

Signed-off-by: Denis Golovin <[email protected]>
redhat-developer · May 1, 2024 · 9d112f8 · 9d112f8
1 parent de68c3d
commit 9d112f8
Showing 1 changed file with 38 additions and 10 deletions.
diff --git a/src/extension.ts b/src/extension.ts
@@ -35,6 +35,7 @@ interface InternalRegistryInfo {
   host: string;
   username: string;
   token: string;
+  namespace?: string;
 }
 
 const StartedStatus: extensionApi.ProviderConnectionStatus = 'started';
@@ -49,6 +50,9 @@ async function whoami(clusterUrl: string, token: string): Promise<string> {
     headers: {
       Authorization: `Bearer ${token}`,
     },
+    https: {
+      rejectUnauthorized: false,
+    },
   };
 
   const username: string = await got(`${clusterUrl}/apis/user.openshift.io/v1/users/~`, gotOptions).then(response => {
@@ -64,12 +68,16 @@ async function whoami(clusterUrl: string, token: string): Promise<string> {
 async function getOpenShiftInternalRegistryPublicHost(contextName: string): Promise<InternalRegistryInfo> {
   const config = kubeconfig.createOrLoadFromFile(extensionApi.kubernetes.getKubeconfig().fsPath);
   const context = config.getContextObject(contextName);
+  const namespace = context.namespace;
   const cluster = config.getCluster(context.cluster);
   const user = config.getUser(context.user);
   const gotOptions = {
     headers: {
       Authorization: `Bearer ${user.token}`,
     },
+    https: {
+      rejectUnauthorized: false,
+    },
   };
   const publicRegistry: string = await got(
     `${cluster.server}/apis/image.openshift.io/v1/namespaces/openshift/imagestreams`,
@@ -90,6 +98,7 @@ async function getOpenShiftInternalRegistryPublicHost(contextName: string): Prom
   return {
     host,
     username,
+    namespace,
     token: user.token,
   };
 }
@@ -101,10 +110,18 @@ export async function pushImageToOpenShiftRegistry(image: ImageInfo): Promise<vo
     .filter(connection => connection.status === 'started')
     .map(connection => connection.connection.name);
   if (!qp.length) {
-    extensionApi.window.showInformationMessage(
-      'You have no running Developer Sandbox connections. Please create new one and try again.',
+    // try to use crc contexts
+    const config = kubeconfig.createOrLoadFromFile(extensionApi.kubernetes.getKubeconfig().fsPath);
+    const crcContexts = config.contexts.filter(context =>
+      config.getCluster(context.cluster).server.startsWith(`https://api.crc.testing`),
     );
-    return;
+    if (crcContexts.length === 0) {
+      extensionApi.window.showInformationMessage(
+        'You have no running Developer Sandbox connections. Please create new one and try again.',
+      );
+      return;
+    }
+    crcContexts.forEach(ct => qp.push(ct.name));
   }
   let targetSb: string;
   if (qp.length > 1) {
@@ -130,14 +147,25 @@ export async function pushImageToOpenShiftRegistry(image: ImageInfo): Promise<vo
         const imageShortName = lastIndexOfSlash !== -1 ? image.name.substring(lastIndexOfSlash + 1) : image.name;
         const imageTagSuffix = image.tag ? `:${image.tag}` : ``;
         const localImageName = `${image.name}${imageTagSuffix}`;
-        const remoteImageName = `${registryInfo.host}/${registryInfo.username}-dev/${imageShortName}${imageTagSuffix}`;
+        const remoteImageName = registryInfo.namespace
+          ? `${registryInfo.host}/${registryInfo.namespace}/${imageShortName}${imageTagSuffix}`
+          : `${registryInfo.host}/${registryInfo.username}-dev/${imageShortName}${imageTagSuffix}`;
         if (localImageName !== remoteImageName) {
-          await extensionApi.containerEngine.tagImage(
-            image.engineId,
-            image.name + imageTagSuffix,
-            `${registryInfo.host}/${registryInfo.username}-dev/${imageShortName}`,
-            image.tag,
-          );
+          if (registryInfo.namespace) {
+            await extensionApi.containerEngine.tagImage(
+              image.engineId,
+              image.name + imageTagSuffix,
+              `${registryInfo.host}/${registryInfo.namespace}/${imageShortName}`,
+              image.tag,
+            );
+          } else {
+            await extensionApi.containerEngine.tagImage(
+              image.engineId,
+              image.name + imageTagSuffix,
+              `${registryInfo.host}/${registryInfo.username}-dev/${imageShortName}`,
+              image.tag,
+            );
+          }
         }
         progress.report({ increment: 75 });
         await new Promise(async (resolve, reject) => {